[PATCH] efi_driver: simplify efi_bl_bind()

AKASHI Takahiro takahiro.akashi at linaro.org
Mon Sep 13 08:01:47 CEST 2021


blk_create_devicef() is what blk_create_device() +
device_set_name_alloced() really does.
The resultant name will be a bit changed.

Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
---
 lib/efi_driver/efi_block_device.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/lib/efi_driver/efi_block_device.c b/lib/efi_driver/efi_block_device.c
index 0937e3595a43..b81c75868eb4 100644
--- a/lib/efi_driver/efi_block_device.c
+++ b/lib/efi_driver/efi_block_device.c
@@ -159,15 +159,11 @@ static int efi_bl_bind(efi_handle_t handle, void *interface)
 	sprintf(name, "efiblk#%d", devnum);
 
 	/* Create driver model udevice for the EFI block io device */
-	ret = blk_create_device(parent, "efi_blk", name, IF_TYPE_EFI, devnum,
-				io->media->block_size,
-				(lbaint_t)io->media->last_block, &bdev);
+	ret = blk_create_devicef(parent, "efi_blk", name, IF_TYPE_EFI, devnum,
+				 io->media->block_size,
+				 (lbaint_t)io->media->last_block, &bdev);
 	if (ret)
 		return ret;
-	if (!bdev)
-		return -ENOENT;
-	/* Set the DM_FLAG_NAME_ALLOCED flag to avoid a memory leak */
-	device_set_name_alloced(bdev);
 
 	plat = dev_get_plat(bdev);
 	plat->handle = handle;
-- 
2.33.0



More information about the U-Boot mailing list