[PATCH v2 6/6] net: dsa: felix: propagate the error code from phy_startup()

Ramon Fried rfried.dev at gmail.com
Tue Sep 14 11:24:13 CEST 2021


On Tue, Aug 24, 2021 at 3:01 PM Vladimir Oltean <vladimir.oltean at nxp.com> wrote:
>
> Make sure that the link status returned by phy_startup() is propagated
> to the .start() method of struct eth_ops.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean at nxp.com>
> Reviewed-by: Ramon Fried <rfried.dev at gmail.com>
> Tested-by: Michael Walle <michael at walle.cc>
> ---
>  drivers/net/mscc_eswitch/felix_switch.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/mscc_eswitch/felix_switch.c b/drivers/net/mscc_eswitch/felix_switch.c
> index c8ecf4f19442..6aa79784460d 100644
> --- a/drivers/net/mscc_eswitch/felix_switch.c
> +++ b/drivers/net/mscc_eswitch/felix_switch.c
> @@ -352,9 +352,7 @@ static int felix_port_enable(struct udevice *dev, int port,
>                  FELIX_QSYS_SYSTEM_SW_PORT_LOSSY |
>                  FELIX_QSYS_SYSTEM_SW_PORT_SCH(1));
>
> -       phy_startup(phy);
> -
> -       return 0;
> +       return phy_startup(phy);
>  }
>
>  static void felix_port_disable(struct udevice *dev, int pidx,
> --
> 2.25.1
>
Applied to u-boot-net/network-master
Thanks,
Ramon.


More information about the U-Boot mailing list