[PATCH v3 27/29] arm: dts: ls1028a: drop non-removable property from esdhc controller node

Vladimir Oltean vladimir.oltean at nxp.com
Wed Sep 15 02:17:29 CEST 2021


On Thu, Sep 02, 2021 at 06:45:56PM +0200, Michael Walle wrote:
> The linux device tree hasn't set this property. To be similarly we remove

s/similarly/similar/

> it from the u-boot device tree, too. The second controller of the
> LS1028A has indeed no card detect pin.

Because it is an eMMC controller.

> The present state register of the
> second controller will always report the card as present. Thus, there
> should be no functional change otherwise than one more register access
> to read the present state.

Tested?

> The property should still be introduced in
> the linux device tree.

How do you feel about dropping this patch?

> 
> Signed-off-by: Michael Walle <michael at walle.cc>
> ---
>  arch/arm/dts/fsl-ls1028a.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/dts/fsl-ls1028a.dtsi b/arch/arm/dts/fsl-ls1028a.dtsi
> index d2f558d208..af6dabe847 100644
> --- a/arch/arm/dts/fsl-ls1028a.dtsi
> +++ b/arch/arm/dts/fsl-ls1028a.dtsi
> @@ -210,7 +210,6 @@
>  			reg = <0x0 0x2150000 0x0 0x10000>;
>  			interrupts = <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
>  			big-endian;
> -			non-removable;
>  			bus-width = <4>;
>  			status = "disabled";
>  		};
> -- 
> 2.30.2
> 


More information about the U-Boot mailing list