[PATCH] i2c: rcar_i2c: Enable configuring SCL rise and fall times

Marek Vasut marex at denx.de
Tue Sep 21 06:20:03 CEST 2021


On 9/21/21 6:13 AM, Heiko Schocher wrote:
> Hello Adam,
> 
> On 20.09.21 14:21, Adam Ford wrote:
>> On Tue, Aug 24, 2021 at 9:10 AM Adam Ford <aford173 at gmail.com> wrote:
>>>
>>> The Linux i2c driver supports i2c-scl-rising-time-ns,
>>> and i2c-scl-falling-time-ns, but U-Boot uses hard-coded values
>>> for these values.
>>>
>>> Update the calculation by fetching them from the device tree if
>>> present and use the previous values as the default if they are
>>> missing.
>>>
>>> Signed-off-by: Adam Ford <aford173 at gmail.com>
>>>
>> Do I have the right people in copy?  I was hoping to get some feedback
>> on this.  My boards use the i2c-scl-rising-time-ns to help properly
>> set the i2c clocking.
> 
> No, I think all fine, for me the patch is okay, so:
> 
> Reviewed-by: Heiko Schocher <hs at denx.de>
> 
> Ah, I see, in patchwork the patch is assigned to Marek... added Marek
> to cc.
> 
> @Marek: Is it okay for you, if I pickup the patch, when new u-boot
> version is out? Else you can pick it up.

Looks good, pick it for next please.


More information about the U-Boot mailing list