[PATCH v2 19/23] sunxi: Remove non-DM MMC pin setup

Andre Przywara andre.przywara at arm.com
Fri Apr 1 01:21:06 CEST 2022


On Thu, 17 Mar 2022 22:54:16 -0500
Samuel Holland <samuel at sholland.org> wrote:

> This is now handled automatically by the pinctrl driver.
> 
> Signed-off-by: Samuel Holland <samuel at sholland.org>

The comment was slightly wrong, this function really only does pinmux
setup, and doesn't touch any clocks. So this is fine now:

Reviewed-by: Andre Przywara <andre.przywara at arm.com>

Cheers,
Andre

> ---
> 
> (no changes since v1)
> 
>  board/sunxi/board.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/board/sunxi/board.c b/board/sunxi/board.c
> index 77ceefdb46..9a18399294 100644
> --- a/board/sunxi/board.c
> +++ b/board/sunxi/board.c
> @@ -241,17 +241,6 @@ int board_init(void)
>  		}
>  	}
>  
> -#ifdef CONFIG_DM_MMC
> -	/*
> -	 * Temporary workaround for enabling MMC clocks until a sunxi DM
> -	 * pinctrl driver lands.
> -	 */
> -	mmc_pinmux_setup(CONFIG_MMC_SUNXI_SLOT);
> -#if CONFIG_MMC_SUNXI_SLOT_EXTRA != -1
> -	mmc_pinmux_setup(CONFIG_MMC_SUNXI_SLOT_EXTRA);
> -#endif
> -#endif	/* CONFIG_DM_MMC */
> -
>  	return 0;
>  }
>  



More information about the U-Boot mailing list