[PATCH] env: Fix avoid using a leftover text-environment file

Sean Anderson seanga2 at gmail.com
Mon Apr 4 01:57:10 CEST 2022


On 4/3/22 7:17 PM, Marek Vasut wrote:
> Clean build ends up generating the following error, add -f switch to rm
> to mitigate it:
> "
> rm: cannot remove 'include/generated/env.in': No such file or directory
> "
> 
> Fixes: f432eb6d8a9 ("env: Avoid using a leftover text-environment file")
> Cc: Sean Anderson <seanga2 at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Tom Rini <trini at konsulko.com>
> ---
>   Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 4672147318e..868445bf33c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1846,7 +1846,7 @@ quiet_cmd_gen_envp = ENVP    $@
>   			-I$(srctree)/arch/$(ARCH)/include \
>   			$< -o $@; \
>   	else \
> -		rm $@; \
> +		rm -f $@; \
>   		touch $@ ; \
>   	fi
>   include/generated/env.in: include/generated/env.txt FORCE
> 

Duplicate of https://patchwork.ozlabs.org/project/uboot/patch/20220403140603.26029-1-andrey.zhizhikin@leica-geosystems.com/

Either one LGTM

Reviewed-by: Sean Anderson <seanga2 at gmail.com>

Tom, this should probably go in the release.

--Sean


More information about the U-Boot mailing list