[PATCH] misc: atsha204a: Fix big endian support

Marek Behún marek.behun at nic.cz
Mon Apr 4 09:57:36 CEST 2022


On Sun,  3 Apr 2022 00:36:34 +0200
Pali Rohár <pali at kernel.org> wrote:

> Callers of function atsha204a_crc16() expect to return value in host cpu
> endianity. So remove cpu_to_le16() conversion.
> 
> Signed-off-by: Pali Rohár <pali at kernel.org>
> ---
>  drivers/misc/atsha204a-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/atsha204a-i2c.c b/drivers/misc/atsha204a-i2c.c
> index b89463babb56..63fe541dade3 100644
> --- a/drivers/misc/atsha204a-i2c.c
> +++ b/drivers/misc/atsha204a-i2c.c
> @@ -146,7 +146,7 @@ static u16 atsha204a_crc16(const u8 *buffer, size_t len)
>  	while (len--)
>  		crc = crc16_byte(crc, *buffer++);
>  
> -	return cpu_to_le16(crc);
> +	return crc;
>  }
>  
>  static int atsha204a_send(struct udevice *dev, const u8 *buf, u8 len)

Reviewed-by: Marek Behún <marek.behun at nic.cz>


More information about the U-Boot mailing list