[PATCH v2 13/18] pci: Map bars with offset and length

Tom Rini trini at konsulko.com
Wed Apr 13 01:11:51 CEST 2022


On Tue, Apr 12, 2022 at 11:54:33PM +0100, Andrew Scull wrote:
> On Tue, 12 Apr 2022 at 17:42, Tom Rini <trini at konsulko.com> wrote:
> >
> > On Tue, Mar 29, 2022 at 04:58:55PM +0000, Andrew Scull wrote:
> >
> > > Evolve dm_pci_map_bar() to include an offset and length parameter. These
> > > allow a portion of the memory to be mapped and range checks to be
> > > applied.
> > >
> > > Passing both the offset and length as zero results in the previous
> > > behaviour and this is used to migtate the previous callers.
> > >
> > > Signed-off-by: Andrew Scull <ascull at google.com>
> >
> > This breaks rpi_arm64 building, and possibly others.  It may be helpful
> > to read https://u-boot.readthedocs.io/en/latest/develop/ci_testing.html
> > and get a CI run completed for the whole series to shake out any other
> > failures.  Thanks!
> 
> That CI sounds like it will be useful to know how to use, thanks for
> the pointers.
> 
> Aside from just building, I'd also be interested in feedback as to
> whether this evolution of the API is a suitable direction to be
> taking.

Ah.  To be clear, I was preparing to merge the series and ran in to this
problem.  So, I think it's fine once CI passes.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220412/f688f97e/attachment.sig>


More information about the U-Boot mailing list