[RFC] disk: don't compile in partition support for spl/tpl if not really necessary

[Tom Rini]

On Fri, Apr 15, 2022 at 10:21:39AM +0200, Heinrich Schuchardt wrote:
> On 4/15/22 09:11, AKASHI Takahiro wrote:
> > We see some increase of spl code size due to partition support (disk/*)
> > while none of particular partition types (CONFIG_SPL_XXX_PARTITION) are
> > enabled.
> > With this patch applied, part.c is no longer included unless really
> > necessary.
> > 
> > In addition, fix errors in CI build revealed after this change is made.
> > 
> > Fixes: commit 88ca8e26958b ("disk: Add an option for partitions in SPL")
> > Fixes: commit 17f8cda505e3 ("efi_loader: set partition GUID in device path
> > 	for SIG_TYPE_GUID")
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
> > ---
> >   cmd/Kconfig                                  |  1 +
> >   configs/cortina_presidio-asic-emmc_defconfig |  1 -
> >   disk/Kconfig                                 | 37 ++++++++++----------
> >   fs/fat/fat.c                                 |  3 +-
> >   include/part.h                               | 14 ++++++--
> >   include/sandboxblockdev.h                    |  2 ++
> >   lib/efi_loader/Kconfig                       |  1 +
> >   7 files changed, 37 insertions(+), 22 deletions(-)
> > 
> > diff --git a/cmd/Kconfig b/cmd/Kconfig
> > index d3abe3a06bff..b69c26912568 100644
> > --- a/cmd/Kconfig
> > +++ b/cmd/Kconfig
> > @@ -1239,6 +1239,7 @@ config CMD_OSD
> > 
> >   config CMD_PART
> >   	bool "part"
> > +	depends on PARTITIONS
> >   	select HAVE_BLOCK_DEVICE
> >   	select PARTITION_UUIDS
> >   	help
> > diff --git a/configs/cortina_presidio-asic-emmc_defconfig b/configs/cortina_presidio-asic-emmc_defconfig
> > index c22dcef7ec05..c217a00a1cf0 100644
> > --- a/configs/cortina_presidio-asic-emmc_defconfig
> > +++ b/configs/cortina_presidio-asic-emmc_defconfig
> > @@ -18,7 +18,6 @@ CONFIG_LAST_STAGE_INIT=y
> >   CONFIG_SYS_PROMPT="G3#"
> >   CONFIG_CMD_I2C=y
> >   CONFIG_CMD_MMC=y
> > -CONFIG_CMD_PART=y
> >   CONFIG_CMD_WDT=y
> >   CONFIG_BOOTP_BOOTFILESIZE=y
> >   CONFIG_CMD_CACHE=y
> 
> This change seems to be unrelated to the commit message.
> 
> Why would you remove the command on a board that supports EXT2 and EXT4
> as well as partitions?

I bet this is part of re-syncing the defconfigs afterwards.  It is OK to
omit these changes in general.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220415/276be186/attachment.sig>