[RFC] disk: don't compile in partition support for spl/tpl if not really necessary

Tom Rini trini at konsulko.com
Fri Apr 15 14:33:21 CEST 2022


On Fri, Apr 15, 2022 at 04:11:56PM +0900, AKASHI Takahiro wrote:

> We see some increase of spl code size due to partition support (disk/*)
> while none of particular partition types (CONFIG_SPL_XXX_PARTITION) are
> enabled.
> With this patch applied, part.c is no longer included unless really
> necessary.
> 
> In addition, fix errors in CI build revealed after this change is made.
> 
> Fixes: commit 88ca8e26958b ("disk: Add an option for partitions in SPL")
> Fixes: commit 17f8cda505e3 ("efi_loader: set partition GUID in device path
> 	for SIG_TYPE_GUID")
> Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>

I assume you did a spot-check for size changes before/after on this.  In
general, I think this is the right way forward and I'll do a world
before/after to check for any cases of "oops, we seem to have lost
functionality".

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220415/23cae1aa/attachment.sig>


More information about the U-Boot mailing list