[PATCH 04/11] arm: mach-k3: Introduce the basic files to support AM62

Tom Rini trini at konsulko.com
Fri Apr 15 18:27:45 CEST 2022


On Fri, Apr 15, 2022 at 07:39:24PM +0530, Vignesh Raghavendra wrote:

[snip]
> diff --git a/arch/arm/mach-k3/am625_init.c b/arch/arm/mach-k3/am625_init.c
> new file mode 100644
> index 0000000000..ee902a774e
> --- /dev/null
> +++ b/arch/arm/mach-k3/am625_init.c
> @@ -0,0 +1,254 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * AM625: SoC specific initialization
> + *
> + * Copyright (C) 2020-2022 Texas Instruments Incorporated - https://www.ti.com/
> + *	Suman Anna <s-anna at ti.com>
> + */
> +
> +#include <common.h>
> +#include <spl.h>
> +#include <asm/io.h>
> +#include <asm/arch/hardware.h>
> +#include <asm/arch/sysfw-loader.h>
> +#include "common.h"
> +#include <dm.h>
> +#include <dm/uclass-internal.h>
> +#include <dm/pinctrl.h>

Er, common.h twice?  Please re-check this, and then also drop common.h
(here and elsewhere) as it only includes other headers and we should
avoid it when possible.  In fact, checkpatch.pl complains about both
dm.h and common.h so please address series-wide, thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220415/ecbb00a2/attachment.sig>


More information about the U-Boot mailing list