[RFC] disk: don't compile in partition support for spl/tpl if not really necessary
AKASHI Takahiro
takahiro.akashi at linaro.org
Mon Apr 18 10:14:56 CEST 2022
Hi Tom,
Thank you for evaluating the code growth.
On Fri, Apr 15, 2022 at 11:01:48PM -0400, Tom Rini wrote:
> On Fri, Apr 15, 2022 at 04:11:56PM +0900, AKASHI Takahiro wrote:
> > We see some increase of spl code size due to partition support (disk/*)
> > while none of particular partition types (CONFIG_SPL_XXX_PARTITION) are
> > enabled.
> > With this patch applied, part.c is no longer included unless really
> > necessary.
> >
> > In addition, fix errors in CI build revealed after this change is made.
> >
> > Fixes: commit 88ca8e26958b ("disk: Add an option for partitions in SPL")
> > Fixes: commit 17f8cda505e3 ("efi_loader: set partition GUID in device path
> > for SIG_TYPE_GUID")
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
> > ---
> > cmd/Kconfig | 1 +
> > configs/cortina_presidio-asic-emmc_defconfig | 1 -
>
> So, the defconfig change here is wrong, CMD_PART isn't being implied
> otherwise,
As I said in my reply to Heinrich, this defconfig seems weird.
but that's okay as I found another workaround.
> and this board is part of a number of boards that had
> EFI_LOADER before, but not DOS_PARTITION, and so do grow, but in a
> valid/expected way. There are also a number of boards that don't have
> any partition type support set, but that too I think ends up being
> correct. The whole before/after is at
> https://gist.github.com/trini/731ee8d50a9bc96b90e12860f8c53f14
That happens, probably, because EFI_LOADER is by default enabled
for most platforms whether users want to use UEFI or not.
I don't think that people who want to use UEFI with U-Boot will
be much careful of the code increase by this change.
Anyway, I will drop this hunk("select DOS_PARTITION) in the next version
as I found another way to fix the dependency issue.
-Takahiro Akashi
> --
> Tom
More information about the U-Boot
mailing list