[PATCH 2/7] binman: Collect bintools for images when replacing entries

[Simon Glass]

On Sun, 27 Mar 2022 at 09:32, Alper Nebi Yasak <alpernebiyasak at gmail.com> wrote:
>
> Binman entries can use other executables to compute their data, usually
> in their ObtainContents() methods. Subclasses of Entry_section would use
> bintools in their BuildSectionData() method instead, which is called
> from several places including their Pack().
>
> These binary tools are resolved correctly while building an image from a
> device-tree description so that they can be used from these methods.
> However, this is not being done when replacing entries in an image,
> which can result in an error as the Pack() methods attempt to use them.
>
> Collect and resolve entries' bintools also when replacing entries to fix
> Pack() errors. Add a way to mock bintool usage in the testing entry type
> and tests that check bintools are being resolved for such an entry.
>
> Signed-off-by: Alper Nebi Yasak <alpernebiyasak at gmail.com>
> ---
>
>  tools/binman/control.py                       |  1 +
>  tools/binman/etype/_testing.py                | 36 +++++++++++++++++
>  tools/binman/ftest.py                         | 38 ++++++++++++++++++
>  .../binman/test/232_replace_with_bintool.dts  | 39 +++++++++++++++++++
>  4 files changed, 114 insertions(+)
>  create mode 100644 tools/binman/test/232_replace_with_bintool.dts

Reviewed-by: Simon Glass <sjg at chromium.org>