[PATCH v2] IOMUX: Fix access past end of console_devices

Tom Rini trini at konsulko.com
Wed Apr 20 15:11:34 CEST 2022


On Wed, Apr 06, 2022 at 02:36:35PM -0400, Sean Anderson wrote:

> We should only access console_devices[file][i] once we have checked that i
> < cd_count[file]. Otherwise, we will access uninitialized memory at the end
> of the loop. console_devices[file][i] should not be NULL, but putting the
> assignment in the loop condition allows us to ensure that i is checked
> beforehand. This isn't a bug, but it does make valgrind stop complaining.
> 
> Fixes: 400797cad3 ("IOMUX: Split out for_each_console_dev() helper macro")
> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
> Reviewed-by: Andrew Scull <ascull at google.com>
> Acked-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220420/b726aaf4/attachment.sig>


More information about the U-Boot mailing list