[PATCH v2] SPL: Do not enable SPL_SYS_MALLOC_SIMPLE without SPL_FRAMEWORK by default

Tom Rini trini at konsulko.com
Fri Apr 22 01:56:43 CEST 2022


On Fri, Apr 08, 2022 at 10:28:05AM +0200, Pali Rohár wrote:

> On P2020 board is SPL malloc simple always failing with error and loops:
> 
>   SD boot...
>   alloc space exhausted
>   Bad trap at PC: f8f8b5f0, SR: 21200, vector=d00
>   NIP: 00000000 XER: 00000000 LR: 00000000 REGS: f8f8b5f0 TRAP: 20000000 DAR: 00000000
>   MSR: 00021200 EE: 0 PR: 0 FP: 0 ME: 1 IR/DR: 00
> 
>   GPR00: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
>   GPR08: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
>   GPR16: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
>   GPR24: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
>   Call backtrace:
>   Exception in kernel pc f8f8b5f0 signal 0
> 
> Inspection showed that gd->malloc_limit is zero. And it is because
> generally SPL_FRAMEWORK initialize SPL's gd->malloc_limit. But when
> SPL_FRAMEWORK is not enabled then in most cases nobody initialize
> gd->malloc_limit and so SPL malloc simple does not work.
> 
> So disable SPL_SYS_MALLOC_SIMPLE by default when SPL_FRAMEWORK is not
> enabled. SPL_SYS_MALLOC_SIMPLE can be disabled only by setting
> SPL_SYS_MALLOC_F_LEN to zero. So do it.
> 
> This change fixes SPL error "alloc space exhausted" on P2020 board.
> 
> Signed-off-by: Pali Rohár <pali at kernel.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220421/5550d658/attachment.sig>


More information about the U-Boot mailing list