[PATCH v3] board: purism: add the Purism Librem5 phone

Angus Ainslie angus at akkea.ca
Fri Apr 22 19:52:29 CEST 2022


On 2022-04-22 02:15, Stefano Babic wrote:
> Hi Angus,
> 
> On 20.04.22 20:13, Angus Ainslie wrote:
>> Initial commit of Librem5 u-boot and SPL
>> 

[snip]

> 
> 
> After merging a patch on dwc3, build reports some warnings (functions
> defined and not used). Could you fix them ?
> 

This patch should silence the warnings

https://lists.denx.de/pipermail/u-boot/2022-April/482313.html

[snip]

>> +
>> +#define CONFIG_MMCROOT			"/dev/mmcblk0p2"  /* USDHC1 */
> 
> You do not use this in your code, and this variable was drop in
> another series and it is not more in the whitelist. Simply drop the
> line.
> 
> 

I'll fix that up in v4

Thanks
Angus

>> +
>> +#define CONFIG_SYS_SDRAM_BASE           0x40000000
>> +#define PHYS_SDRAM                      0x40000000
>> +#define PHYS_SDRAM_SIZE			0xc0000000 /* 3GB LPDDR4 one Rank */
>> +
>> +/* Monitor Command Prompt */
>> +#define CONFIG_SYS_CBSIZE              1024
>> +#define CONFIG_SYS_MAXARGS             64
>> +#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
>> +#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
>> +					sizeof(CONFIG_SYS_PROMPT) + 16)
>> +#define CONFIG_SYS_FSL_ESDHC_ADDR       0
>> +
>> +#endif
> 
> Best regards,
> Stefano


More information about the U-Boot mailing list