[PATCH v3 3/6] clk: meson: update driver for g12a-ao clocks

Neil Armstrong narmstrong at baylibre.com
Mon Apr 25 09:21:18 CEST 2022


On 24/04/2022 10:21, Vyacheslav Bocharov wrote:
> Update g12a-ao clk driver:
> - move clk->id check to .request function
> - remove unnecessary check (gate->reg == 0)
> 
> Signed-off-by: Vyacheslav Bocharov <adeep at lexina.in>
> ---
>   drivers/clk/meson/g12a-ao.c | 15 +++++++++------
>   1 file changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/clk/meson/g12a-ao.c b/drivers/clk/meson/g12a-ao.c
> index 17b11eb52a..1a855a6896 100644
> --- a/drivers/clk/meson/g12a-ao.c
> +++ b/drivers/clk/meson/g12a-ao.c
> @@ -28,14 +28,8 @@ static int meson_set_gate(struct clk *clk, bool on)
>   	struct meson_clk *priv = dev_get_priv(clk->dev);
>   	struct meson_gate *gate;
>   
> -	if (clk->id >= ARRAY_SIZE(gates))
> -		return -ENOENT;
> -
>   	gate = &gates[clk->id];
>   
> -	if (gate->reg == 0)
> -		return 0;
> -
>   	regmap_update_bits(priv->map, gate->reg,
>   			   BIT(gate->bit), on ? BIT(gate->bit) : 0);
>   
> @@ -63,9 +57,18 @@ static int meson_clk_probe(struct udevice *dev)
>   	return 0;
>   }
>   
> +static int meson_clk_request(struct clk *clk)
> +{
> +	if (clk->id >= ARRAY_SIZE(gates))
> +		return -ENOENT;
> +
> +	return 0;
> +}
> +
>   static struct clk_ops meson_clk_ops = {
>   	.disable	= meson_clk_disable,
>   	.enable		= meson_clk_enable,
> +	.request	= meson_clk_request,
>   };
>   
>   static const struct udevice_id meson_clk_ids[] = {

Acked-by: Neil Armstrong <narmstrong at baylibre.com>


More information about the U-Boot mailing list