[PATCH] power: domain: apple: Restore reset ops that return 0

Mark Kettenis mark.kettenis at xs4all.nl
Tue Apr 26 22:54:20 CEST 2022


> Date: Tue, 26 Apr 2022 21:01:01 +0200
> From: Marek Vasut <marex at denx.de>
> 
> On 4/26/22 20:21, Mark Kettenis wrote:
> >> Date: Tue, 26 Apr 2022 20:04:19 +0200
> >> From: Marek Vasut <marex at denx.de>
> >>
> >> On 4/26/22 19:14, Mark Kettenis wrote:
> >>> These were removed inadvertently in commit 20874a60722b.
> >>> Fixes a crash on Apple M1 systems.
> >>
> >> The drivers/power/domain/power-domain-uclass.c should handle empty
> >> implementation of request/rfree callback in exactly the commit you
> >> reference above.
> > 
> > Yes, but drivers/reset/reset-uclass.c doesn't and you also removed the
> > request/rfree callbacks for that part of the apple_pmgr driver.
> 
> Ah, sigh. Would it rather make sense to change the reset uclass ?
> It would reduce the amount of empty callbacks.

Maybe.  But that should probably done as a single sweep like you did
for the power domains.  Let's fix this crash first.


More information about the U-Boot mailing list