[PATCH v5 07/12] efi_loader: disk: a helper function to create efi_disk objects from udevice

[Johan Jonker]

On 4/19/22 03:05, AKASHI Takahiro wrote:

>  
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index bc518d7a413b..6b245f50a726 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -14,6 +14,8 @@ config EFI_LOADER
>  	depends on DM_ETH || !NET
>  	depends on !EFI_APP
>  	default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8

> +	select DM_EVENT
> +	select EVENT_DYNAMIC

Hi,

The use of this select without EVENT leads to this warning:

WARNING: unmet direct dependencies detected for EVENT_DYNAMIC
  Depends on [n]: EVENT [=n]
  Selected by [y]:
  - EFI_LOADER [=y] && OF_LIBFDT [=y] && (ARM [=y] && (SYS_CPU
[=armv7]=arm1136 || SYS_CPU [=armv7]=arm1176 || SYS_CPU [=armv7]=armv7
|| SYS_CPU [=armv7]=armv8) || X86 [=n] || RISCV [=n] || SANDBOX [=n]) &&
(!EFI_STUB [=n] || !X86_64 [=n] || EFI_STUB_64BIT [=n]) && (!EFI_STUB
[=n] || !X86 [=n] || X86_64 [=n] || EFI_STUB_32BIT [=n]) && BLK [=y] &&
(DM_ETH [=n] || !NET [=n]) && !EFI_APP [=n]

Previously there was no need for events on rk3066.
Is that normal behavior or should we include "select EVENT" here as well?

Johan

>  	select LIB_UUID
>  	imply PARTITION_UUIDS
>  	select HAVE_BLOCK_DEVICE
> @@ -40,6 +42,7 @@ config CMD_BOOTEFI_BOOTMGR
>  
>  config EFI_SETUP_EARLY
>  	bool
> +	default y
>  
>  choice
>  	prompt "Store for non-volatile UEFI variables"