[PATCH 1/2] ARM: cache: Allow SPL to build cache-pl310.c

[Philip Oberfichtner]

On Thu, 2022-08-04 at 11:02 +0200, Marek Vasut wrote:
> On 8/4/22 10:15, Philip Oberfichtner wrote:
> > Before this commit, the SPL could enable the PL310 L2 cache [1],
> > but the
> > cache maintenance functions from cache-pl310.c were only useable
> > for
> > non-SPL builds.
> > 
> > After enabling the cache one must be able to flush it, too. Thus
> > this
> > commit allows cache-pl310.c to be included in the SPL build.
> > 
> > [1] See for example arch/arm/mach-imx/cache.c:
> > v7_outer_cache_enable()
> > 
> > Signed-off-by: Philip Oberfichtner <pro at denx.de>
> > ---
> > 
> >   arch/arm/lib/Makefile | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/lib/Makefile b/arch/arm/lib/Makefile
> > index c603fe61bc..ac1d4245bb 100644
> > --- a/arch/arm/lib/Makefile
> > +++ b/arch/arm/lib/Makefile
> > @@ -33,7 +33,6 @@ obj-$(CONFIG_OF_LIBFDT) += bootm-fdt.o
> >   obj-$(CONFIG_CMD_BOOTI) += bootm.o image.o
> >   obj-$(CONFIG_CMD_BOOTM) += bootm.o
> >   obj-$(CONFIG_CMD_BOOTZ) += bootm.o zimage.o
> > -obj-$(CONFIG_SYS_L2_PL310) += cache-pl310.o
> >   else
> >   obj-$(CONFIG_$(SPL_TPL_)FRAMEWORK) += spl.o
> >   obj-$(CONFIG_SPL_FRAMEWORK) += zimage.o
> > @@ -46,6 +45,7 @@ else
> >   obj-$(CONFIG_$(SPL_TPL_)USE_ARCH_MEMSET) += memset.o
> >   obj-$(CONFIG_$(SPL_TPL_)USE_ARCH_MEMCPY) += memcpy.o
> >   endif
> > +obj-$(CONFIG_SYS_L2_PL310) += cache-pl310.o
> 
> Doesn't this need SPL/TPL Kconfig symbols and
> 
> obj-$(CONFIG_$(SPL_TPL_)SYS_L2_PL310) += cache-pl310.o
> 
> ?

CONFIG_SYS_L2_PL310 is not converted to Kconfig yet. And there is no
CONFIG_SPL_ usage for it so far. So I'd say no. Please correct me if
I'm wrong.