[PATCH 1/2] ARM: cache: Allow SPL to build cache-pl310.c

Marek Vasut marex at denx.de
Thu Aug 4 13:33:56 CEST 2022


On 8/4/22 11:19, Philip Oberfichtner wrote:

[...]

>>> @@ -46,6 +45,7 @@ else
>>>    obj-$(CONFIG_$(SPL_TPL_)USE_ARCH_MEMSET) += memset.o
>>>    obj-$(CONFIG_$(SPL_TPL_)USE_ARCH_MEMCPY) += memcpy.o
>>>    endif
>>> +obj-$(CONFIG_SYS_L2_PL310) += cache-pl310.o
>>
>> Doesn't this need SPL/TPL Kconfig symbols and
>>
>> obj-$(CONFIG_$(SPL_TPL_)SYS_L2_PL310) += cache-pl310.o
>>
>> ?
> 
> CONFIG_SYS_L2_PL310 is not converted to Kconfig yet. And there is no
> CONFIG_SPL_ usage for it so far. So I'd say no. Please correct me if
> I'm wrong.

I'm concerned whether applying this patch won't enable L2CC in SPL for 
boards where this could break things.

There is a script to do the conversion to Kconfig easily, see 
doc/develop/moveconfig.rst . It might make sense to run it first, 
convert this symbol to Kconfig, and then add this patch second, and then 
enable SPL_...PL310 for this board only.


More information about the U-Boot mailing list