[PATCH v2 1/2] ARM: cache: Allow SPL to build cache-pl310.c

Marek Vasut marex at denx.de
Mon Aug 8 14:52:02 CEST 2022


On 8/8/22 14:29, Philip Oberfichtner wrote:
> 
> 
> On Thu, 2022-08-04 at 07:05 -0400, Tom Rini wrote:
>> On Thu, Aug 04, 2022 at 12:56:45PM +0200, Philip Oberfichtner wrote:
>>
>>> Before this commit, the SPL could enable the PL310 L2 cache [1],
>>> but the
>>> cache maintenance functions from cache-pl310.c were only useable
>>> for
>>> non-SPL builds.
>>>
>>> After enabling the cache one must be able to flush it, too. Thus
>>> this
>>> commit allows cache-pl310.c to be included in the SPL build.
>>>
>>> [1] See for example arch/arm/mach-imx/cache.c:
>>> v7_outer_cache_enable()
>>>
>>> Signed-off-by: Philip Oberfichtner <pro at denx.de>
>>
>> It should be rather direct to migrate this to Kconfig, please do that
>> first, and introduce CONFIG_SPL_SYS_L2_PL310.  Thanks!
>>
> 
> Hi,
> 
> converting CONFIG_SYS_L2_PL310 - no problem. For SYS_PL310_BASE the
> moveconfig tool just hangs indefinitely on every defconfig that needs
> conversion. Do you have any hints on this issue?
> 
> Below the Kconfig entry, that I used.
> 
> config SYS_PL310_BASE
>         depends on SYS_L2_PL310
>         hex "Base address of PL310"

Try adding default values for known architectures/socs (use git grep in 
include/configs/ and sort -u to find out)
default 0x1234ab00 if ARCH_FOO
default 0x4321cd00 if ARCH_BAR

>         help
>           Physical base address of PL310 controller register space



More information about the U-Boot mailing list