[PATCH v2 1/2] ARM: cache: Allow SPL to build cache-pl310.c

Tom Rini trini at konsulko.com
Mon Aug 8 15:35:04 CEST 2022


On Mon, Aug 08, 2022 at 02:29:02PM +0200, Philip Oberfichtner wrote:
> 
> 
> On Thu, 2022-08-04 at 07:05 -0400, Tom Rini wrote:
> > On Thu, Aug 04, 2022 at 12:56:45PM +0200, Philip Oberfichtner wrote:
> > 
> > > Before this commit, the SPL could enable the PL310 L2 cache [1],
> > > but the
> > > cache maintenance functions from cache-pl310.c were only useable
> > > for
> > > non-SPL builds.
> > > 
> > > After enabling the cache one must be able to flush it, too. Thus
> > > this
> > > commit allows cache-pl310.c to be included in the SPL build.
> > > 
> > > [1] See for example arch/arm/mach-imx/cache.c:
> > > v7_outer_cache_enable()
> > > 
> > > Signed-off-by: Philip Oberfichtner <pro at denx.de>
> > 
> > It should be rather direct to migrate this to Kconfig, please do that
> > first, and introduce CONFIG_SPL_SYS_L2_PL310.  Thanks!
> > 
> 
> Hi,
> 
> converting CONFIG_SYS_L2_PL310 - no problem. For SYS_PL310_BASE the
> moveconfig tool just hangs indefinitely on every defconfig that needs
> conversion. Do you have any hints on this issue?
> 
> Below the Kconfig entry, that I used.
> 
> config SYS_PL310_BASE
>        depends on SYS_L2_PL310
>        hex "Base address of PL310"
>        help
>          Physical base address of PL310 controller register space

We can just skip that one for the moment, it's a bit tricky. It
shouldn't be asked for as it's not configurable, it needs to be a list
of default X if ARCH_Y. Thanks for looking at this one too!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220808/cf3d82f0/attachment.sig>


More information about the U-Boot mailing list