[PATCH 1/1] Kconfig: clean up skipping low-level initialization

[Tom Rini]

On Fri, Dec 30, 2022 at 11:51:14AM -0600, Simon Glass wrote:
> Hi Heinrich,
> 
> On Fri, 30 Dec 2022 at 08:01, Heinrich Schuchardt
> <heinrich.schuchardt at canonical.com> wrote:
> >
> > It is confusing if multiple Kconfig entries have the same title.
> >
> > Use different titles for main U-Boot, SPL, TPL.
> > Put all entries for skipping low-level initialization into a sub-menu.
> >
> > Fixes: a2ac2b964bfb ("Convert CONFIG_SKIP_LOWLEVEL_INIT et al to Kconfig")
> > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> > ---
> >  arch/Kconfig | 20 ++++++++++++--------
> >  1 file changed, 12 insertions(+), 8 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> See below
> 
> >
> > diff --git a/arch/Kconfig b/arch/Kconfig
> > index 102956d24c..112dcfe00f 100644
> > --- a/arch/Kconfig
> > +++ b/arch/Kconfig
> > @@ -381,9 +381,11 @@ config SYS_IMMR
> >           Address for the Internal Memory-Mapped Registers (IMMR) window used
> >           to configure the features of many Freescale / NXP SoCs.
> >
> > -config SKIP_LOWLEVEL_INIT
> > -       bool "Skip the calls to certain low level initialization functions"
> > +menu "Skipping low level initialization functions"
> >         depends on ARM || MIPS || RISCV
> > +
> > +config SKIP_LOWLEVEL_INIT
> > +       bool "Skip calls to certain low level initialization functions"
> >         help
> >           If enabled, then certain low level initializations (like setting up
> >           the memory controller) are omitted and/or U-Boot does not relocate
> > @@ -393,8 +395,8 @@ config SKIP_LOWLEVEL_INIT
> >           debugger which performs these initializations itself.
> >
> >  config SPL_SKIP_LOWLEVEL_INIT
> > -       bool "Skip the calls to certain low level initialization functions"
> > -       depends on SPL && (ARM || MIPS || RISCV)
> > +       bool "Skip SPL calls to certain low level initialization functions"
> 
> This sounds like SPL calls are a thing, but really all calls in SPL
> are SPL calls.
> 
> So how about: Skip calls to certain low-level-initialization functions in SPL

Yes please, as that's the form all of the other wordings like this take.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20221230/782be23b/attachment.sig>