[PATCH v1] mmc: fsl_esdhc_imx: fix watermark level in dma

Fabio Estevam festevam at gmail.com
Wed Feb 2 18:08:53 CET 2022


On Mon, Jan 31, 2022 at 10:44 PM Fabio Estevam <festevam at gmail.com> wrote:
>
> Hi Marcel,
>
> On Mon, Jan 31, 2022 at 7:08 PM Marcel Ziswiler <marcel at ziswiler.com> wrote:
> >
> > From: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> >
> > Seems that we need the waterlevel setting not only for PIO mode as
> > without this at least the i.MX 8M Mini won't boot anymore when being
> > written by such a U-Boot. Corruption has also been observed both on
> > the i.MX 6 as well as i.MX 8M Mini when using ums on the eMMC. Fix
> > this by setting the watermark level again regardless of whether in
> > DMA or PIO mode.
> >
> > Fixes: 41c6a22fc296 ("mmc: fsl_esdhc_imx: simplify esdhc_setup_data()")
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler at toradex.com>
>
> This is probably the failure I saw on imx7 when I tried testing 'ums'.
>
> Reviewed-by: Fabio Estevam <festevam at gmail.com>

This indeed fixes the regression I was seeing with imx7s-warp:

Tested-by: Fabio Estevam <festevam at gmail.com>


More information about the U-Boot mailing list