[PATCH v2 5/5] sunxi-common.h: remove pointless #ifdefs

Samuel Holland samuel at sholland.org
Thu Feb 3 02:07:35 CET 2022


On 1/31/22 7:41 PM, Andre Przywara wrote:
> Remove some pointless #ifdefs from this file, as there are quite too
> many of them already.
> 
> Some definitions don't really hurt to have in any case, so remove the
> pointless CONFIG_MMC guard around CONFIG_MMC_SUNXI_SLOT.
> 
> The BOARD_SIZE_LIMIT applies regardless of ARM64 or not (now), so remove
> that guard as well. The maximum number of MMC devices does not depend on
> CONFIG_ENV_IS_IN_MMC, so move that out to simplify the file.
> 
> Last but not least CONFIG_SPL_BOARD_LOAD_IMAGE serves no real purpose
> anymore: it's unconditionally defined for all sunxi boards, and protects
> nothing applicable outside of sunxi code anymore. Just remove it.
> 
> Reviewed-by: Samuel Holland <samuel at sholland.org>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> Tested-by: Simon Glass <sjg at chromium.org>
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>

Even with the SMPEN code missing from SPL, for the series:

Tested-by: Samuel Holland <samuel at sholland.org>
Tested-on: Orange Pi Plus 2E


More information about the U-Boot mailing list