[PATCH] Nokia RX-51: Convert to CONFIG_DM_KEYBOARD

Tom Rini trini at konsulko.com
Thu Feb 3 22:53:07 CET 2022


On Thu, Feb 03, 2022 at 04:45:44PM -0500, Tom Rini wrote:
> On Thu, Feb 03, 2022 at 04:16:23PM -0500, Tom Rini wrote:
> > On Thu, Feb 03, 2022 at 07:38:50PM +0100, Pali Rohár wrote:
> > 
> > > Signed-off-by: Pali Rohár <pali at kernel.org>
> > > ---
> > > 
> > > I would really appreciate if U-Boot test framework starts printing
> > > deprecation warnings, instead of sending patches which directly drop
> > > support for some boards.
> > > 
> > > There is absolutely no warning during building U-Boot for RX-51 board
> > > that this board has not been converted to DM_KEYBOARD yet.
> > 
> > Please send some patch that implements what you're wanting to see for
> > how to make the warnings more visible.  I do agree the warning for
> > v2022.10 only showed up after the merge to -next once v2022.01 came out,
> > but it's still a fairly long time to clean up the few unconverted
> > boards.
> 
> Oh, I see what's going on.  Simon, the DM_KEYBOARD check isn't
> triggering for any boards.  I'll look more.

And here's where we're at.  nokia_rx51 doesn't set CONFIG_KEYBOARD, so
didn't trigger the warning about  migration.  Every platform that sets
CONFIG_KEYBOARD is migrated.  I don't know how many other platforms are
in the situation nokia_rx51 is in.  Yanking out the legacy code and
seeing what fails to build, and going from there is probably the next
option.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220203/9a56c9f6/attachment.sig>


More information about the U-Boot mailing list