[PATCH v2 2/3] dts: sama5d2: add TCB node

[Eugen.Hristev at microchip.com]

Hello Clement,

Subject should be ARM: dts: [at91:] sama5d2: ...

On 2/2/22 4:43 PM, Clément Léger wrote:
> Add the device-tree node to describe the TCB timer.
> 
> Signed-off-by: Clément Léger <clement.leger at bootlin.com>
> ---
>   arch/arm/dts/sama5d2.dtsi | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi
> index 038cd73c03..fc6a4fbe4d 100644
> --- a/arch/arm/dts/sama5d2.dtsi
> +++ b/arch/arm/dts/sama5d2.dtsi
> @@ -700,6 +700,21 @@
>                                  clocks = <&h32ck>;
>                          };
> 
> +                       tcb0: timer at f800c000 {
> +                               compatible = "atmel,sama5d2-tcb", "simple-mfd";

syscon ?

> +                               reg = <0xf800c000 0x100>;
> +
> +                               clocks = <&tcb0_clk>, <&tcb0_gclk>, <&clk32k>;
> +                               clock-names = "t0_clk", "gclk", "slow_clk";
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +
> +                               timer0: timer at 0 {
> +                                       compatible = "atmel,tcb-timer";
> +                                       reg = <0>, <1>;
> +                               };
> +                       };
> +

I am not happy that the original binding has the interrupts as 
'mandatory'. Maybe the binding author did not have more use cases in mind.
Anyway I think that it can go to u-boot without this interrupts property 
as it's surely unused and there is no interrupt controller at the moment 
in the DT.
If nobody has another opinion that is...

Eugen

>                          watchdog at f8048040 {
>                                  compatible = "atmel,sama5d4-wdt";
>                                  reg = <0xf8048040 0x10>;
> --
> 2.34.1
>