[PATCH v2] mkimage: Improve documentation of algo-name parameter

Jan Kiszka jan.kiszka at siemens.com
Sat Feb 5 13:19:36 CET 2022


From: Jan Kiszka <jan.kiszka at siemens.com>

Addresses the feedback provided on 5902a397d029 which raced with the
merge.

Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
Reviewed-by: Simon Glass <sjg at chromium.org>
---

Change in v2:
 - rewrap also_name comment

 doc/mkimage.1     | 2 +-
 tools/imagetool.h | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/doc/mkimage.1 b/doc/mkimage.1
index 0734bd36a11..fc84cca066b 100644
--- a/doc/mkimage.1
+++ b/doc/mkimage.1
@@ -158,7 +158,7 @@ CONFIG_OF_CONTROL in U-Boot.
 .TP
 .BI "\-o [" "signing algorithm" "]"
 Specifies the algorithm to be used for signing a FIT image. The default is
-taken from the target signature nodes 'algo' properties.
+taken from the signature node's 'algo' property.
 
 .TP
 .BI "\-p [" "external position" "]"
diff --git a/tools/imagetool.h b/tools/imagetool.h
index a4105515d81..c3f80fc64e8 100644
--- a/tools/imagetool.h
+++ b/tools/imagetool.h
@@ -71,7 +71,9 @@ struct image_tool_params {
 	const char *keydest;	/* Destination .dtb for public key */
 	const char *keyfile;	/* Filename of private or public key */
 	const char *comment;	/* Comment to add to signature node */
-	const char *algo_name;	/* Algorithm name to use hashing/signing */
+	/* Algorithm name to use for hashing/signing or NULL to use the one
+	 * specified in the its */
+	const char *algo_name;
 	int require_keys;	/* 1 to mark signing keys as 'required' */
 	int file_size;		/* Total size of output file */
 	int orig_file_size;	/* Original size for file before padding */
-- 
2.34.1


More information about the U-Boot mailing list