[RFC PATCH v1 16/21] test: hush: Fix variable expansion tests for hush 2021.

[Francis Laniel]

Le mercredi 12 janvier 2022, 21:03:37 CET Simon Glass a écrit :
> Hi Francis,
> 
> On Fri, 31 Dec 2021 at 09:14, Francis Laniel
> 
> <francis.laniel at amarulasolutions.com> wrote:
> > This commit modifies the expected result for hush 2021.
> > Indeed, there were bugs in actual U-Boot hush which were fixed in upstream
> > Busybox.
> > As hush 2021 is based on upstream Busybox, these bugs no longer exist.
> > 
> > Signed-off-by: Francis Laniel <francis.laniel at amarulasolutions.com>
> > ---
> > 
> >  test/hush/dollar.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 51 insertions(+)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> Can you avoid the preprocessor macros?
> 
> Also, for testing we really want to be able to run both sets of tests
> in sandbox, so the parser needs to be run-time selectable.

To be sure, you would like to have a global variable named, for example, 
parser which value could be:
* parser = "old", for old hush parser
* parser = "2021", for "new" hush parser
Is my understanding correct?

> Regards,
> Simon