[PATCH v2 3/5] binman: Check missing bintools of Section subclasses

Alper Nebi Yasak alpernebiyasak at gmail.com
Mon Feb 7 23:08:06 CET 2022

Binman can check for missing binary tools and prints warnings if
anything required for an image is missing. The implementation of this
for the Section entry only checks the subentries, presumably because
Section does not use any binary tools itself. However, this means the
check is also skipped for subclasses of Section which might need binary

Make sure missing binary tools are checked for subclasses of the Section
entry type as well, by calling the parent class' implementation in
the relevant Section method.

Signed-off-by: Alper Nebi Yasak <alpernebiyasak at gmail.com>
Reviewed-by: Simon Glass <sjg at chromium.org>
This starts being tested by testFitMissing in the next patch when FIT
becomes a Section subclass.

Changes in v2:
- Add tag: "Reviewed-by: Simon Glass <sjg at chromium.org>"

 tools/binman/etype/section.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/binman/etype/section.py b/tools/binman/etype/section.py
index bb375e9063df..213a510a8d5b 100644
--- a/tools/binman/etype/section.py
+++ b/tools/binman/etype/section.py
@@ -840,6 +840,7 @@ def check_missing_bintools(self, missing_list):
             missing_list: List of Bintool objects to be added to
+        super().check_missing_bintools(missing_list)
         for entry in self._entries.values():

More information about the U-Boot mailing list