[PATCH v3] board: gateworks: venice: add imx8mn-gw7902 support
tharvey at gateworks.com
Fri Feb 11 17:21:36 CET 2022
On Thu, Feb 10, 2022 at 5:51 PM Fabio Estevam <festevam at gmail.com> wrote:
> Hi Tim,
> Your patch looks good.
> On Wed, Feb 2, 2022 at 7:00 PM Tim Harvey <tharvey at gateworks.com> wrote:
> > +/* Initial environment variables */
> > +#define CONFIG_EXTRA_ENV_SETTINGS \
> > + BOOTENV \
> > + MEM_LAYOUT_ENV_SETTINGS \
> > + "script=boot.scr\0" \
> > + "bootm_size=0x10000000\0" \
> > + "ipaddr=192.168.1.22\0" \
> > + "serverip=192.168.1.146\0" \
> It is not recommended to place hardcode ipaddr and serverip in the
> default environment.
> Please remove them.
> > +/* FEC */
> > +#define CONFIG_ETHPRIME "eth0"
> > +#define CONFIG_FEC_XCV_TYPE RGMII
> > +#define CONFIG_FEC_MXC_PHYADDR 0
> > +#define FEC_QUIRK_ENET_MAC
> > +#define IMX_FEC_BASE 0x30BE0000
> No need to pass IMX_FEC_BASE as the Ethernet driver model is used.
> Reviewed-by: Fabio Estevam <festevam at gmail.com>
Thanks for the review - I will post a v4.
More information about the U-Boot