[PATCH V3 1/2] fw_env: make flash_io() take buffer as an argument

Tom Rini trini at konsulko.com
Fri Feb 11 18:05:30 CET 2022

On Wed, Jan 12, 2022 at 12:47:05PM +0100, Rafał Miłecki wrote:

> From: Rafał Miłecki <rafal at milecki.pl>
> It's usually easier to understand code & follow it if all arguments are
> passed explicitly. Many coding styles also discourage using global
> variables.
> Behaviour of flash_io() was a bit unintuitive as it was writing to a
> buffer referenced in a global struct. That required developers to
> remember how it works and sometimes required hacking "environment"
> global struct variable to read data into a proper buffer.
> Signed-off-by: Rafał Miłecki <rafal at milecki.pl>

Applied to u-boot/master, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220211/1de24f0c/attachment.sig>

More information about the U-Boot mailing list