[PATCH] arm: apple: Disable debug UART

[Heinrich Schuchardt]

On 2/11/22 22:01, Simon Glass wrote:
> Hi Mark,
>
> On Fri, 11 Feb 2022 at 13:50, Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
>>
>>> From: Simon Glass <sjg at chromium.org>
>>> Date: Fri, 11 Feb 2022 13:29:15 -0700
>>>
>>> Hi Mark,
>>>
>>> On Fri, 11 Feb 2022 at 13:00, Mark Kettenis <kettenis at openbsd.org> wrote:
>>>>
>>>> The address of the debug UART varies differs between the M1 and
>>>> the M1 Pro/Max SoCs.  So we have to disable it to make a single
>>>> U-Boot binary that works on all SoC generations.  Leave the
>>>> settings for the base address and clock rate of the M1 in place
>>>> to make it easier to re-enable the debug UART when needed.
>>>
>>> How about adding some docs about how to, and what the addresses are?
>>
>> Yes I can do that.  A section at the end of doc/board/apple/m1.rst?

Just list the relevant settings like in

doc/board/sipeed/maix.rst:591
doc/board/emulation/qemu-arm.rst:118


>> Is it ok if I provide a single update to that file for the M1 Pro/Max
>> support?
>
> Sounds right, just enough to explain how to enable it.
>
> Regards,
> Simon
>
>>
>>>> Signed-off-by: Mark Kettenis <kettenis at openbsd.org>
>>>> ---
>>>>   configs/apple_m1_defconfig | 1 -
>>>>   1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig
>>>> index ef5b7ffd1a..396fe63114 100644
>>>> --- a/configs/apple_m1_defconfig
>>>> +++ b/configs/apple_m1_defconfig
>>>> @@ -3,7 +3,6 @@ CONFIG_ARCH_APPLE=y
>>>>   CONFIG_DEFAULT_DEVICE_TREE="t8103-j274"
>>>>   CONFIG_DEBUG_UART_BASE=0x235200000
>>>>   CONFIG_DEBUG_UART_CLOCK=24000000

Please, use 'make savedefconfig' to create a consistent defconfig, and
copy the generated defconfig to configs/apple_m1_defconfig before
resubmitting.

Best regards

Heinrich

>>>> -CONFIG_DEBUG_UART=y
>>>>   CONFIG_SYS_LOAD_ADDR=0x0
>>>>   CONFIG_USE_PREBOOT=y
>>>>   # CONFIG_DISPLAY_CPUINFO is not set
>>>> --
>>>> 2.35.1
>>>>
>>>
>>> Regards,
>>> SImon
>>>