[PATCH 1/3] mmc: fsl_esdhc_imx: use VENDORSPEC_FRC_SDCLK_ON when necessary

[Bough Chen]

Hi Fabio,

Can you help test these 3 patches on imx6qdl-pico board or imx7s board on your side to double check whether these patches enlarge the total boot time?

Best Regards
Bough Chen

> -----Original Message-----
> From: Marek Vasut [mailto:marex at denx.de]
> Sent: 2022年2月14日 5:53
> To: Bough Chen <haibo.chen at nxp.com>; Peng Fan <peng.fan at nxp.com>;
> jh80.chung at samsung.com; festevam at gmail.com; sean.anderson at seco.com;
> u-boot at lists.denx.de; aford173 at gmail.com; tharvey at gateworks.com;
> andrey.zhizhikin at leica-geosystems.com
> Cc: dl-uboot-imx <uboot-imx at nxp.com>
> Subject: Re: [PATCH 1/3] mmc: fsl_esdhc_imx: use
> VENDORSPEC_FRC_SDCLK_ON when necessary
> 
> On 2/11/22 12:16, haibo.chen at nxp.com wrote:
> 
> Hi,
> 
> [...]
> 
> > @@ -897,6 +900,11 @@ static int fsl_esdhc_execute_tuning(struct udevice
> *dev, uint32_t opcode)
> >
> >   	esdhc_stop_tuning(mmc);
> >
> > +	/* change to default setting, let host control the card clock */
> > +	esdhc_clrbits32(&regs->vendorspec, VENDORSPEC_FRC_SDCLK_ON);
> > +	if (readx_poll_timeout(esdhc_read32, &regs->prsstat, tmp, tmp &
> PRSSTAT_SDOFF, 100))
> 
> Please propagate the error in both cases:
> 
> ret = readx_poll..();
> if (ret)
>    dev_warn(...);
> 
> return ret;
> 
> > +		pr_warn("fsl_esdhc_imx: card clock not gate off as expect.\n");
> 
> btw. s at gate@gated@ , s at expect@expected@ (past tense)
> 
> With those small details fixed:
> 
> Reviewed-by: Marek Vasut <marex at denx.de>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 9551 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220214/99503d84/attachment.bin>