[PATCH] usb: ehci-omap: Drop dead code

Marek Vasut marex at denx.de
Mon Feb 14 04:10:41 CET 2022


On 2/14/22 01:05, Adam Ford wrote:
> On Sat, Feb 12, 2022 at 8:26 AM Adam Ford <aford173 at gmail.com> wrote:
>>
>> omap_ehci_hcd_stop appears to be dead code, and omap_ehci_hcd_init
>> is only called by the probe function, so it can be static to that
>> function.  Remove both from the header along with some additional
>> checking for DM_USB.
>>
> 
> If it's not too late to hold off on this, I'd like to resend it as
> part of a larger series.  I have a whole series based on this that
> converts the driver to use the phy subsystem in an effort to remove
> the OMAP_EHCI_PHYx_RESET_GPIO from Kconfig that makes the driver more
> device-tree friendly.  Rather than doing this and waiting for the
> reviews, merge, etc.  then doing the follow-up, I'd like to just send
> the series to avoid confusion as to any dependent patches.
> 
> If it's too late, I'll just send the subsequent patches after this one
> gets reviewed and merged.

It is not too late, but make sure you CC someone who can actually test 
this EHCI OMAP stuff.


More information about the U-Boot mailing list