[PATCH] rpi: always set fdt_addr to the correct value

Matthias Brugger mbrugger at suse.com
Tue Feb 15 15:55:54 CET 2022



On 18/02/2022 03:44, Jaehoon Chung wrote:
> On 22. 2. 14. 20:25, Marek Szyprowski wrote:
>> The fdt_addr env have meaning only for the current runtime and it depends
>> on the dtb size or firmware version. If one save the environment to disk
>> and the loads it on the latter boot, the fdt_addr might change, what
>> result in passing incorrect dtb address to the kernel. Fix this by always
>> setting the fdt_addr env. This fixes system operation after saving the
>> env to disk and updating i.e. dtb files or firmware.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com>
> 
> Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>
> 

Could we keep the discussion where we left it the last time you submitted the patch?

Thanks! :)

Regards,
Matthias

> Best Regards,
> Jaehoon Chung
> 
>> ---
>>   board/raspberrypi/rpi/rpi.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c
>> index bc3cc597adb..6d6d2e69234 100644
>> --- a/board/raspberrypi/rpi/rpi.c
>> +++ b/board/raspberrypi/rpi/rpi.c
>> @@ -347,9 +347,6 @@ static void set_fdtfile(void)
>>    */
>>   static void set_fdt_addr(void)
>>   {
>> -	if (env_get("fdt_addr"))
>> -		return;
>> -
>>   	if (fdt_magic(fw_dtb_pointer) != FDT_MAGIC)
>>   		return;
>>   
> 



More information about the U-Boot mailing list