[PATCH] ti: i2c: fix probe_chip() return value

Nikita Yushchenko nikita.yoush at cogentembedded.com
Tue Feb 15 19:10:09 CET 2022


Per documentation, dm_i2c_ops.probe_chip() shall return -EREMOTEIO if
probe fails.

Currently, omap_i2c_probe_chip() returns 1 instead. Fix that.

Signed-off-by: Nikita Yushchenko <nikita.yoush at cogentembedded.com>
---
 drivers/i2c/omap24xx_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c
index a767dee986..0e149dcb0b 100644
--- a/drivers/i2c/omap24xx_i2c.c
+++ b/drivers/i2c/omap24xx_i2c.c
@@ -1015,7 +1015,7 @@ static int omap_i2c_probe_chip(struct udevice *bus, uint chip_addr,
 	struct omap_i2c *priv = dev_get_priv(bus);
 
 	return __omap24_i2c_probe(priv->regs, priv->ip_rev, priv->waitdelay,
-				  chip_addr);
+				  chip_addr) ? -EREMOTEIO : 0
 }
 
 static int omap_i2c_probe(struct udevice *bus)
-- 
2.30.2



More information about the U-Boot mailing list