[PATCH] lib: acpi: rename dsdt.c to acpi_write_dsdt.c

[Simon Glass]

Hi Philippe,

On Thu, 17 Feb 2022 at 09:10, Philippe Reynes
<philippe.reynes at softathome.com> wrote:
>
> There is a conflict between the static file
> lib/acpi/dsdt.c and the file dsdt.c generated
> dynamicaly by scripts/Makefile.lib. When a
> mrproper is done, the static file dsdt.c is
> removed. If a build with acpi enabled is
> launched after, the following error is raised:
>
>   CC      lib/acpi/acpi_table.o
> make[2]: *** No rule to make target 'lib/acpi/dsdt.asl', needed by 'lib/acpi/dsdt.c'.  Stop.
> scripts/Makefile.build:394: recipe for target 'lib/acpi' failed
>
> To avoid such error, the static file dsdt.c
> is renamed to acpi_write_dsdt.c.
>
> Signed-off-by: Philippe Reynes <philippe.reynes at softathome.com>
> ---
>  lib/acpi/Makefile                      | 2 +-
>  lib/acpi/{dsdt.c => acpi_write_dsdt.c} | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename lib/acpi/{dsdt.c => acpi_write_dsdt.c} (100%)

Reviewed-by: Simon Glass <sjg at chromium.org>

I would prefer that we change the 'rm' to be deterministic in this
case, as we do with other filenames. One way would be to change the
Makefile.lib rule to:

$(obj)/dsdt_generated.c:    $(src)/dsdt.asl

then at least the generated file has a name that distinguishes it.

Regards,
Simon