[PATCH v2] imx8m: clock_imx8mq: Add the ecspi clocks

[Stefano Babic]

On 15.02.22 21:26, Marek Vasut wrote:
> On 2/15/22 18:58, Angus Ainslie wrote:
>> On 2022-02-15 08:45, Marek Vasut wrote:
>>> On 2/15/22 15:55, Angus Ainslie wrote:
>>>> On 2022-02-15 00:01, Marek Vasut wrote:
>>>>> On 2/15/22 01:51, Angus Ainslie wrote:
>>>>>> On 2022-02-14 16:25, Marek Vasut wrote:
>>>>>>> On 2/14/22 21:51, Angus Ainslie wrote:
>>>>>>>> Enable the clocks for spi buses 1 through 3
>>>>>>>>
>>>>>>>> Signed-off-by: Angus Ainslie <angus at akkea.ca>
>>>>>>>> ---
>>>>>>>>
>>>>>>>> Changes since v1:
>>>>>>>>
>>>>>>>> added MXC_CSPI_CLK to ECSPI1_CLK_ROOT mapping
>>>>>>>>
>>>>>>>>   arch/arm/include/asm/arch-imx8m/imx-regs.h |  9 +++++
>>>>>>>>   arch/arm/mach-imx/imx8m/clock_imx8mq.c     | 40 
>>>>>>>> ++++++++++++++++++++++
>>>>>>>>   2 files changed, 49 insertions(+)
>>>>>>>
>>>>>>> Shouldn't all this come from DT ?
>>>>>>
>>>>>> This is used in the SPL.
>>>>>>
>>>>>> The imx8mq also doesn't have a DM clock driver.
>>>>>
>>>>> Hmm, would it be possible to take one of the other Ms clock drivers,
>>>>> fork it into MQ one, and fill in the tables from Linux, thus creating
>>>>> the missing MQ clock driver?
>>>>
>>>> I've begun working on that as well. I'll send the patches once I get 
>>>> Linux to boot.
>>>
>>> Thanks
>>>
>>> Does it make sense to wait with this patch for after 2022.04 , when it
>>> might not be needed ?
>>>
>>> I'll let Stefano decide ...
>>
>> Ok, I'm not sure why it should get held back as it fixes ECSPI 
>> initialization and use in the SPL.
> 
> It also enables extra clock unconditionally and there is this "TODO" 
> right in the middle of the patch.

Right, I agree.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================