[PATCH] armv8: fsl-layerscape: use previous aligned address for gic_lpi_base

Michael Walle michael at walle.cc
Mon Feb 21 11:24:36 CET 2022


Hi,

Am 2022-02-21 11:16, schrieb Wasim Khan:
> From: Wasim Khan <wasim.khan at nxp.com>
> 
> Memory after gd->arch.resv_ram is reserved for MC block.
> Use ALIGN_DOWN to avoid updating MC block for unaligned
> address.

I cannot really tell what you are trying to do here. But I
know Marc has offered to also take a look at the GIC/LPI
stuff. So I've put him on CC.

-michael

> 
> Signed-off-by: Wasim Khan <wasim.khan at nxp.com>
> ---
>  arch/arm/cpu/armv8/fsl-layerscape/soc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> index d3a5cfaac1..746c93cf51 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> @@ -65,7 +65,7 @@ int ls_gic_rd_tables_init(void *blob)
>  	u64 gic_lpi_base;
>  	int ret;
> 
> -	gic_lpi_base = ALIGN(gd->arch.resv_ram - GIC_LPI_SIZE, SZ_64K);
> +	gic_lpi_base = ALIGN_DOWN(gd->arch.resv_ram - GIC_LPI_SIZE, SZ_64K);
>  	ret = fdt_add_resv_mem_gic_rd_tables(blob, gic_lpi_base, 
> GIC_LPI_SIZE);
>  	if (ret)
>  		return ret;


More information about the U-Boot mailing list