[PATCH] core: devres: don't use devres code when CONFIG_DEVRES is not defined
Angus Ainslie
angus at akkea.ca
Mon Feb 21 13:50:46 CET 2022
Hi Simon,
On 2022-02-19 14:12, Simon Glass wrote:
> On Wed, 2 Feb 2022 at 16:16, Angus Ainslie <angus at akkea.ca> wrote:
>>
>> Put guards around the devres code so that it isn't compiled during the
>> SPL.
>>
>> Signed-off-by: Angus Ainslie <angus at akkea.ca>
>> ---
>> drivers/core/devres.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> I think the correct fix here is to change the Makefile rule for this
> file to use
>
> CONFIG_$(SPL_)DEVRES
>
> instead of
>
> CONFIG_DEVRES
>
> Can you try it?
>
I think it will work that way and I did think about doing the patch that
way. My concern was that it might break some boards because they are
expecting DEVRES in the SPL.
I can rework the patch that way but not sure how I'd test which boards
needed the CONFIG_SPL_DEVRES defined.
Thanks
Angus
> Regards,
> Simon
> [..]
More information about the U-Boot
mailing list