[PATCH v2] ARM: imx: imx8mn-ddr4-evk: Add ethernet support

Frieder Schrempf frieder.schrempf at kontron.de
Tue Feb 22 08:35:53 CET 2022

Hi Marek,

Am 21.02.22 um 17:49 schrieb Marek Vasut:
> On 2/21/22 11:10, Michael Walle wrote:
> Hi,
>>> +int board_phy_config(struct phy_device *phydev)
>>> +{
>>> +    /* enable rgmii rxc skew and phy mode select to RGMII copper */
>>> +    phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x1f);
>>> +    phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x8);
>>> +
>>> +    phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x00);
>>> +    phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x82ee);
>>> +    phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05);
>>> +    phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x100);
>> This is a AR8031, correct?  Is there a reason why you don't use the
>> device tree binding to set RGMII voltage, and RX and tx delays?
> I quickly cobbled this together from another board, since I needed
> ethernet to do other tests with this board and the ethernet support was
> missing. If you can send subsequent patch to flip this to DT-only setup,
> I can test the patch on the board.

So why don't you post it as RFC?
To be honest it seems a bit contradictory that you normally take a
critical position on other people's patches when they use legacy code
instead of DM/DT (which is alright) and then send a half-baked approach
yourself and expect other people to fix it for you afterwards.

I don't want to complain, it just occurred to me.


More information about the U-Boot mailing list