[PATCH v2 5/5] binman: Update image positions of FIT subentries

Simon Glass sjg at chromium.org
Wed Feb 23 03:35:17 CET 2022

Hi Alper,

On Mon, 7 Feb 2022 at 15:08, Alper Nebi Yasak <alpernebiyasak at gmail.com> wrote:
> Binman keeps track of positions of each entry in the final image, but
> currently this data is wrong for things included in FIT entries,
> especially since a previous patch makes FIT a subclass of Section and
> inherit its implementation.
> There are three ways to put data into a FIT image. It can be directly
> included as a "data" property, or it can be external to the FIT image
> represented by an offset-size pair of properties. This external offset
> is either "data-position" from the start of the FIT or "data-offset"
> from the end of the FIT, and the size is "data-size" for both. However,
> binman doesn't use the "data-offset" method while building FIT entries.
> According to the Section docstring, its subclasses should calculate and
> set the correct offsets and sizes in SetImagePos() method. Do this for
> FIT subentries for the three ways mentioned above, and add tests for the
> two ways binman can pack them in.
> Signed-off-by: Alper Nebi Yasak <alpernebiyasak at gmail.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> ---
> Changes in v2:
> - Check missing_bintools list instead of catching Fdt exceptions
> - Add tag: "Reviewed-by: Simon Glass <sjg at chromium.org>"
>  tools/binman/etype/fit.py |  51 +++++++++++++++++
>  tools/binman/ftest.py     | 112 ++++++++++++++++++++++++++++++++++++++
>  2 files changed, 163 insertions(+)

As mentioned I had to change the previous patch in a minor way to get
it to apply.

I'd really like to get this in if possible, too. The issue is the
handling of hash nodes in a FIT, as I mentioned.

If you are able to rework this, please let me know.

I've gone ahead sent my fit series but will rebase it onto this patch
if you are able to fix it up.


Applied to u-boot-dm, thanks!

More information about the U-Boot mailing list