[PATCH 5/7] usb: ehci-omap: Use PHY system to manage phy resets

[Marek Vasut]

On 2/20/22 00:08, Adam Ford wrote:

[...]

> @@ -364,7 +356,21 @@ static int omap_ehci_probe(struct udevice *dev)
>   	hccr = (struct ehci_hccr *)&priv->ehci->hccapbase;
>   	hcor = (struct ehci_hcor *)&priv->ehci->usbcmd;
>   
> -	ret = omap_ehci_hcd_init(0, &usbhs_bdata);
> +	/* Identify Phys */
> +	ret = omap_ehci_phy_get(dev);
> +	if (ret) {
> +		printf("Failed to get phys\n");
> +		return ret;

It would be good to print the return values here (ret=%d), since in case 
there is an actual failure, you can infer what happened from that return 
value without having to patch the code to add that missing return value 
print.

Subsequent patch would be fine, assuming CI passes.

[...]