[PATCH] arm: dts: rk3399-puma: re-add vdd_log for uboot

[Quentin Schulz]

Hi Heiko,

On 12/26/21 13:45, Heiko Stuebner wrote:
> The rk3399-puma board needs a 950mV vdd_log to work stable.
> This was already added in
> commit 77012e79ffc3 ("rockchip: rk3399-puma: Set VDD_LOG to 950 mV")
> but lost again with
> commit 167efc2c7a46 ("arm64: dts: rk3399: Sync v5.7-rc1 from Linux")
> 
> So to make puma stable again re-add the vdd_log pwm regulator.
> As it is not part of the mainline Linux dts right now, add it
> to the -u-boot dtsi for puma.
> 
> Fixes: 167efc2c7a46 ("arm64: dts: rk3399: Sync v5.7-rc1 from Linux")
> Signed-off-by: Heiko Stuebner <heiko at sntech.de>
> ---
>   arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi b/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi
> index 29846c4b00..76eb51d2d7 100644
> --- a/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi
> @@ -49,6 +49,17 @@
>   		regulator-min-microvolt = <1800000>;
>   		regulator-max-microvolt = <1800000>;
>   	};
> +
> +	vdd_log: vdd-log {
> +		compatible = "pwm-regulator";
> +		pwms = <&pwm2 0 25000 1>;
> +		regulator-name = "vdd_log";
> +		regulator-min-microvolt = <800000>;
> +		regulator-max-microvolt = <1400000>;
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-init-microvolt = <950000>;
> +	};
>   };
>   
>   &gpio1 {

Is this a spurious patch by any chance?

https://source.denx.de/u-boot/u-boot/-/commit/1621afc84f8a109cfdb98c9e370c355289e07870 
seems to have more or less the same content, sent (and merged) about a 
year ago by Christoph.

Moreover, it seems to still be there in master: 
https://source.denx.de/u-boot/u-boot/-/blob/master/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi#L52-L62

Cheers,
Quentin