[PATCH v2] rockchip: timer: add OF_PLATDATA support for dw-apb-timer

Simon Glass sjg at chromium.org
Wed Jan 5 15:03:43 CET 2022


Hi Johan,

On Tue, 4 Jan 2022 at 19:15, Johan Jonker <jbx6244 at gmail.com> wrote:
>
> The Rockchip rk3066 SoC has 3 dw-apb-timer nodes.
> U-boot is compiled with OF_PLATDATA TPL/SPL options,
> so add OF_PLATDATA support for the dw-apb-timer.
> Also change driver name to be able to compile with
> U-boot scripts. No reset OF_PLATDATA support was added,
> because the rk3066 nodes don't need/have them.
>
> Signed-off-by: Johan Jonker <jbx6244 at gmail.com>
> ---
>
> Changed V2:
>   replace if (IS_ENABLED(OF_REAL)) by #if CONFIG_IS_ENABLED(OF_REAL)
> ---
>  drivers/timer/dw-apb-timer.c | 30 +++++++++++++++++++++++++-----
>  1 file changed, 25 insertions(+), 5 deletions(-)
>

This seems OK but you have included unrelated changes (whitespace)
which should go in a separate patch.

Can you use if() instead of #if for the CONFIG_IS_ENABLED(OF_REAL) ?

Regards,
Simon


More information about the U-Boot mailing list