[PATCH v8 12/15] Layerscape: Enable Job ring driver model.

[Michael Walle]

Hi,

please keep me on CC for these series, as there were comments
from me on previous versions. Thanks.

..

> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 7ce2bbc954..30a34bdd08 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1504,6 +1504,8 @@ config TARGET_LS1028AQDS
>  	select ARCH_SUPPORT_TFABOOT
>  	select BOARD_LATE_INIT
>  	select GPIO_EXTRA_HEADER
> +	select FSL_CAAM
> +	select MISC

This looks wrong. FSL_CAAM should depend on MISC, no?

>  	help
>  	  Support for Freescale LS1028AQDS platform
>  	  The LS1028A Development System (QDS) is a high-performance
> @@ -1518,6 +1520,8 @@ config TARGET_LS1028ARDB
>  	select ARCH_SUPPORT_TFABOOT
>  	select BOARD_LATE_INIT
>  	select GPIO_EXTRA_HEADER
> +	select FSL_CAAM
> +	select MISC
>  	help
>  	  Support for Freescale LS1028ARDB platform
>  	  The LS1028A Development System (RDB) is a high-performance
> diff --git a/arch/arm/cpu/armv7/ls102xa/Kconfig b/arch/arm/cpu/armv7/ls102xa/Kconfig
> index f919d02db4..ca006e069f 100644
> --- a/arch/arm/cpu/armv7/ls102xa/Kconfig
> +++ b/arch/arm/cpu/armv7/ls102xa/Kconfig
> @@ -21,6 +21,9 @@ config ARCH_LS1021A
>  	select SYS_FSL_SRDS_1
>  	select SYS_HAS_SERDES
>  	select SYS_I2C_MXC
> +	select FSL_CAAM

While above you added that dependency to an indivdual board,
here you are adding that dependency to all boards using this
architecture. The same is true for all the other "config
ARCH_*" symbols. What if someone wants to build a bootloader
without CAAM support? This should really go into the
defconfigs for these boards.

-michael