[EXT] Re: [PATCH v9 11/14] Layerscape: Enable Job ring driver model.

[Michael Walle]

Hi,

Am 2022-01-11 13:55, schrieb Gaurav Jain:
>> >> > diff --git a/configs/ls2088ardb_tfa_defconfig
>> >> > b/configs/ls2088ardb_tfa_defconfig
>> >> > index a28b45b129..5230d7ead8 100644
>> >> > --- a/configs/ls2088ardb_tfa_defconfig
>> >> > +++ b/configs/ls2088ardb_tfa_defconfig
>> >> > @@ -53,7 +53,6 @@ CONFIG_ENV_ADDR=0x580500000
>> >> > CONFIG_NET_RANDOM_ETHADDR=y  CONFIG_DM=y
>> CONFIG_SATA_CEVA=y
>> >> > -CONFIG_FSL_CAAM=y
>> >> >  CONFIG_DDR_CLK_FREQ=133333333
>> >> >  CONFIG_DDR_ECC=y
>> >> >  CONFIG_ECC_INIT_VIA_DDRCONTROLLER=y
>> >> ..
>> >>
>> >> I still don't understand why you make the FSL_CAAM mandatory and
>> >> remove the option here. Same for all other boards.
>> > Instead of enabling FSL_CAAM in every defconfig for a particular
>> > board, I moved FSL_CAAM to specific TARGET boards.
>> > this will enable FSL_CAAM to every defconfig for a target board.
>> 
>> But a user/developer cannot disable that option anymore in this case.
> I have enabled FSL_CAAM only for the boards that are enabling CAAM
> previously as well.
> Current change make it easy, else I have to make change in each
> defconfig for all target boards.

But a defconfig is, as the name says, just the default config. A user
can still disable the CAAM driver. If you instead add it as a
"select FSL_CAAM" to the TARGET_ symbol, the user cannot disable
it anymore.

-michael