[PATCH 3/3] misc: atsha204a: fix i2c address readout from DTS

Adrian Fiergolski adrian.fiergolski at fastree3d.com
Tue Jan 11 18:56:12 CET 2022


Hi Marek,

Thank you for your review.

On 21.12.2021 18:52, Marek Behún wrote:
> On Tue, 21 Dec 2021 17:17:22 +0100
> Adrian Fiergolski <adrian.fiergolski at fastree3d.com> wrote:
>
>> This patch replaces use fdtdec_get_addr with recommended fdtdec_get_addr_size_auto_parent.
> And why is that required?
I didn't debug why exactly, but it didn't work with my embedded system 
based on ZynqMP (64bit). I might guess it's related to the fact that, 
quoting documentation, "This variant hard-codes the number of cells used 
to represent the address and size based on sizeof(fdt_addr_t) and 
sizeof(fdt_size_t)".
> If at all, I would rather change it to simple dev_read_addr().

Good idea, it's much cleaner. I have just confirmed it works as well. I 
will share the new version of the patches.

Adrian



More information about the U-Boot mailing list